chore(demo app): fix remaining webpack build errors#2
Closed
jenny-s51 wants to merge 1 commit into
Closed
Conversation
Merged
1 task
Owner
|
@jenny-s51 Where are you seeing these webpack build errors? I do not see them. |
Author
|
The webpack errors I was seeing earlier were due to local caching issues on my end. After clearing caches and rebuilding, everything works as expected - approving patternfly#284 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes look good with just a couple cleanups needed due to some unsupported/deprecated props and types:
In
OptionsContextBar.tsx, removed theplaceholderprop from the Select component since it's now handled by the MenuToggle component below.NodeJS.Timertype is deprecated, updated it toNodeJS.Timeout.